Pokemon Black and White Swampert Moveset?

Looks good, I personally would use Waterfall over Scald and Ice Punch or Avalanche over Ice Beam. Swampert's base Attack is 110 whereas his Special Attack is only 85, so physical moves would work a little better despite the power difference in Ice Punch/Avalanche over Ice Beam. It's situational though, since your choice of an ice move will hit certain Pokemon harder than others depending on if they are more physically or specially bulky. Avalanche is crappy if you don't get hit the turn you use it though. Scald's 30% burn rate is great, but it's not amazing on a physically bulky Pokemon like Swampert, especially since your Swampert is more offensive based. Scald is usually better on more defensive movesets/Pokemon. Although Waterfall and Scald are both 80 Base Power, Waterfall would hit slightly harder in general because it's physical whereas Scald is special. Most Swamperts in competitive play don't carry three attacking moves either, there usually have something like Roar or Curse but I see yours has a more offensive approach rather than utility. But hey that's just me, go with what fits your needs best.